Bug 125490 – [WK2][SOUP] initialise the Network Process with ignoreTLSErrors

• Component: WebKit2
• Status: RESOLVED FIXED

[Brian Holt]

GTester: last random seed: R02S69550582c8e7a89f180d326b5b541b32
TEST: Programs/WebKit2APITests/TestSSL... (pid=1381)
Gtk-Message: Failed to load module "canberra-gtk-module"
  /webkit2/WebKitWebView/ssl:                                          **
ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp:72:void testSSL(SSLTest*, gconstpointer): assertion failed: (test->m_certificate)
FAIL

The problem is that the ResourceHandleSoup in the Network Process and is not initialised with a policy on ignoring TLS errors.  This simply requires that the appropriate message is created for the Network Process and the parameter created for initialisation.

[Brian Holt]

Created attachment 218849 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 218849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218849&action=review

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:104
> -    parameters.ignoreTLSErrors = m_ignoreTLSErrors;
>      parameters.shouldTrackVisitedLinks = true;
>  #if ENABLE(NETWORK_PROCESS)
>      parameters.usesNetworkProcess = true;
> +#else
> +    parameters.ignoreTLSErrors = m_ignoreTLSErrors;

Looks good to me, pretty sure we'll need this for cookieAcceptPolicy and others as well, maybe we should do the others in one go?

[Kwang Yul Seo]

ignoreTLSErrors can be dynamically set, so WebContext::setIgnoreTLSErrors must be changed to send the message to the network process when network process is enabled.

void WebContext::setIgnoreTLSErrors(bool ignoreTLSErrors)
{
    m_ignoreTLSErrors = ignoreTLSErrors;
    sendToAllProcesses(Messages::WebProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors));
}

[Sergio Villar Senin]

(In reply to comment #3)
> ignoreTLSErrors can be dynamically set, so WebContext::setIgnoreTLSErrors must be changed to send the message to the network process when network process is enabled.
> 
> void WebContext::setIgnoreTLSErrors(bool ignoreTLSErrors)
> {
>     m_ignoreTLSErrors = ignoreTLSErrors;
>     sendToAllProcesses(Messages::WebProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors));
> }

Note that this will send the message to all the WebProcesses but not to the network process.

[WebKit Commit Bot]

Comment on attachment 218849 [details]
Patch

Clearing flags on attachment: 218849

Committed r160355: <http://trac.webkit.org/changeset/160355>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Kwang Yul Seo]

(In reply to comment #4)
> Note that this will send the message to all the WebProcesses but not to the network process.

I field a separate bug for this. See Bug 125505