Bug 125471

Summary:

Begin working on a UserData class intended to replace UserMessageCoders

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2013-12-09 15:50:42 PST

Begin working on a UserData class intended to replace UserMessageCoders

Comment 1 Anders Carlsson 2013-12-09 15:56:55 PST

Created attachment 218809 [details]
Patch

Comment 2 Sam Weinig 2013-12-09 16:01:39 PST

Comment on attachment 218809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218809&action=review

> Source/WebKit2/Shared/APIFrameHandle.h:36
> +    static PassRefPtr<FrameHandle> create(uint64_t frameID);

You said that RefPtr would be fine here.

> Source/WebKit2/Shared/APIPageHandle.h:36
> +    static PassRefPtr<PageHandle> create(uint64_t pageID);

RefPtr here please.

> Source/WebKit2/Shared/UserData.cpp:60
> +        encoder.encodeEnum(API::Object::Type::Null);

You don't deal with decoding this.

Comment 3 Anders Carlsson 2013-12-09 16:08:31 PST

Committed r160341: <http://trac.webkit.org/changeset/160341>