Bug 125460

Summary:

AX: Audio and video attachments at end of a message are not output to VoiceOver

Product:

WebKit

Reporter:

Samuel White <samuel_white>

Component:

Accessibility

Assignee:

Samuel White <samuel_white>

Status:

ASSIGNED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.9

Attachments:

Description	Flags
Patch for EWS.	none
Patch.	none
Updated patch.	cfleizach: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none

Samuel White

Reported 2013-12-09 11:23:35 PST

Audio and video attachments at the end of a Mail message are not navigable by VoiceOver or other AT.

Attachments
Patch for EWS. (1.67 KB, patch) 2013-12-09 12:20 PST, Samuel White	no flags	Details Formatted Diff Diff
Patch. (5.93 KB, patch) 2013-12-09 14:28 PST, Samuel White	no flags	Details Formatted Diff Diff
Updated patch. (5.97 KB, patch) 2013-12-09 14:39 PST, Samuel White	cfleizach: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (742.47 KB, application/zip) 2013-12-09 19:24 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (646.33 KB, application/zip) 2013-12-09 19:41 PST, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Samuel White

Comment 1 2013-12-09 11:24:08 PST

<rdar://problem/15528873>

Samuel White

Comment 2 2013-12-09 12:20:18 PST

Created attachment 218789 [details] Patch for EWS. Looking for initial EWS issues.

WebKit Commit Bot

Comment 3 2013-12-09 12:21:47 PST

Attachment 218789 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/TextIterator.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/editing/TextIterator.cpp:396: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Samuel White

Comment 4 2013-12-09 12:26:56 PST

(In reply to comment #3) > Attachment 218789 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/TextIterator.cpp', '--commit-queue']" exit_code: 1 > ERROR: Source/WebCore/editing/TextIterator.cpp:396: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Caused by: m_endOffset == 0 which is existing code. Will update to: !m_endOffset in next patch.

Samuel White

Comment 5 2013-12-09 14:28:04 PST

Created attachment 218800 [details] Patch. Added layout test.

Samuel White

Comment 6 2013-12-09 14:39:06 PST

Created attachment 218803 [details] Updated patch. Updated patch to fix Changelog text wrapping issue.

Build Bot

Comment 7 2013-12-09 19:24:29 PST

Comment on attachment 218803 [details] Updated patch. Attachment 218803 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46278303 New failing tests: editing/execCommand/remove-format-textdecoration-in-iframe.html editing/style/5228141.html editing/pasteboard/styled-element-markup.html editing/inserting/return-with-object-element.html editing/deleting/delete-start-block.html svg/foreignObject/viewport-foreignobject-crash.html

Build Bot

Comment 8 2013-12-09 19:24:30 PST

Created attachment 218821 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2013-12-09 19:41:52 PST

Comment on attachment 218803 [details] Updated patch. Attachment 218803 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47348076 New failing tests: editing/execCommand/remove-format-textdecoration-in-iframe.html editing/style/5228141.html editing/pasteboard/styled-element-markup.html editing/inserting/return-with-object-element.html editing/deleting/delete-start-block.html svg/foreignObject/viewport-foreignobject-crash.html

Build Bot

Comment 10 2013-12-09 19:41:53 PST

Created attachment 218823 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

chris fleizach

Comment 11 2013-12-13 09:22:36 PST

Comment on attachment 218803 [details] Updated patch. seems ok to me, fairly similar to other recent replaced element patches, but r- for now until you can figure out if the tests are regressions or not

Samuel White

Comment 12 2013-12-16 17:22:41 PST

These failures are fairly involved. Digging through them now.

Note You need to log in before you can comment on or make changes to this bug.