Bug 125451

Summary:

AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, mario, rniwa, samuel_white, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

125450

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Joanmarie Diggs

Reported 2013-12-09 07:12:14 PST

Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests.

Attachments
Patch (85.38 KB, patch) 2013-12-09 07:29 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Patch (88.75 KB, patch) 2013-12-09 08:37 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Patch (88.79 KB, patch) 2013-12-09 09:34 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Patch (88.40 KB, patch) 2013-12-09 10:04 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Joanmarie Diggs

Comment 1 2013-12-09 07:29:10 PST

Created attachment 218757 [details] Patch

Build Bot

Comment 2 2013-12-09 08:04:08 PST

Comment on attachment 218757 [details] Patch Attachment 218757 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/44758142

Build Bot

Comment 3 2013-12-09 08:13:04 PST

Comment on attachment 218757 [details] Patch Attachment 218757 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/47228114

Mario Sanchez Prada

Comment 4 2013-12-09 08:16:20 PST

View in context: https://bugs.webkit.org/attachment.cgi?id=218757&action=review I love this patch. I'm happy to let it in as soon as the Mac build is fixed > Source/WebKit/gtk/tests/testatk.c:-1070 > - webkit_web_view_load_string(webView, contentsWithEmbeddedObjects, 0, 0, 0); Could you remove the contentsWithEmbeddedObjects const variable, as it's not used anymore after the patch? Same applies to other ones that might not be unused too after this > Tools/DumpRenderTree/AccessibilityUIElement.h:220 > + // Text-specific > + JSStringRef characterAtOffset(int offset); > + JSStringRef wordAtOffset(int offset); > + JSStringRef lineAtOffset(int offset); > + JSStringRef sentenceAtOffset(int offset); This functions are quite specifically designed to test the AtkText interface, so I think you should put them under a PLATFORM check for GTK || EFL Otherwise, you'll need to provide dummy implementations for other platforms's versions of AccessibilityUIElement

Build Bot

Comment 5 2013-12-09 08:27:27 PST

Comment on attachment 218757 [details] Patch Attachment 218757 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/44758147

Joanmarie Diggs

Comment 6 2013-12-09 08:37:42 PST

Created attachment 218766 [details] Patch

Build Bot

Comment 7 2013-12-09 09:13:02 PST

Comment on attachment 218766 [details] Patch Attachment 218766 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47238121

Build Bot

Comment 8 2013-12-09 09:19:52 PST

Comment on attachment 218766 [details] Patch Attachment 218766 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/47238124