Bug 125439

Summary:

Move expectation parsing out of the constructor of TestExpectations

Product:

WebKit

Reporter:

Dániel Bátyai <dbatyai.u-szeged>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Dániel Bátyai

Reported 2013-12-09 00:33:02 PST

In layout_tests/models/test_expectations.py there's a FIXME suggesting that the parsing of the expectations should be moved into separate routines from the constructor.

Attachments
Proposed patch (16.57 KB, patch) 2013-12-09 00:34 PST, Dániel Bátyai	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dániel Bátyai

Comment 1 2013-12-09 00:34:23 PST

Created attachment 218728 [details] Proposed patch

Csaba Osztrogonác

Comment 2 2013-12-18 03:09:58 PST

Comment on attachment 218728 [details] Proposed patch LGTM, r=me

WebKit Commit Bot

Comment 3 2013-12-18 03:37:53 PST

Comment on attachment 218728 [details] Proposed patch Clearing flags on attachment: 218728 Committed r160756: <http://trac.webkit.org/changeset/160756>

WebKit Commit Bot

Comment 4 2013-12-18 03:37:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.