Bug 125439 - Move expectation parsing out of the constructor of TestExpectations
Summary: Move expectation parsing out of the constructor of TestExpectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-09 00:33 PST by Dániel Bátyai
Modified: 2013-12-18 03:37 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (16.57 KB, patch)
2013-12-09 00:34 PST, Dániel Bátyai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dániel Bátyai 2013-12-09 00:33:02 PST 
In layout_tests/models/test_expectations.py there's a FIXME suggesting that the parsing of the expectations should be moved into separate routines from the constructor.
Comment 1 Dániel Bátyai 2013-12-09 00:34:23 PST 
Created attachment 218728 [details]
Proposed patch
Comment 2 Csaba Osztrogonác 2013-12-18 03:09:58 PST 
Comment on attachment 218728 [details]
Proposed patch

LGTM, r=me
Comment 3 WebKit Commit Bot 2013-12-18 03:37:53 PST 
Comment on attachment 218728 [details]
Proposed patch

Clearing flags on attachment: 218728

Committed r160756: <http://trac.webkit.org/changeset/160756>
Comment 4 WebKit Commit Bot 2013-12-18 03:37:55 PST 
All reviewed patches have been landed.  Closing bug.