Bug 125435

Summary:

prepare-Changelog treats CSS keyframes as mismatched parentheses

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

bburg, bfulgham, commit-queue, gbalogh.u-szeged, simon.fraser

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
patch	none

Brian Burg

Reported 2013-12-08 20:26:05 PST

Test case which triggers warnings in get_selector_line_ranges_for_css: @-webkit-keyframes blink-plus-icon { 0% { opacity: 1; } 50% { opacity: 0.3; } 100% { opacity: 0; } }

Attachments
patch (1.54 KB, patch) 2013-12-16 06:43 PST, Gergő Balogh	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gergő Balogh

Comment 1 2013-12-16 06:43:38 PST

Created attachment 219311 [details] patch

WebKit Commit Bot

Comment 2 2013-12-16 09:55:06 PST

Comment on attachment 219311 [details] patch Clearing flags on attachment: 219311 Committed r160645: <http://trac.webkit.org/changeset/160645>

WebKit Commit Bot

Comment 3 2013-12-16 09:55:08 PST

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 4 2013-12-16 10:50:54 PST

This may have broken a unit test: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/1538/steps/webkitperl-test/logs/stdio

Brent Fulgham

Comment 5 2013-12-16 10:54:50 PST

(In reply to comment #4) > This may have broken a unit test: > http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/1538/steps/webkitperl-test/logs/stdio It definitely does. Reverting this change fixes the test.

WebKit Commit Bot

Comment 6 2013-12-16 10:56:00 PST

Re-opened since this is blocked by bug 125787

Note You need to log in before you can comment on or make changes to this bug.