Bug 125435 - prepare-Changelog treats CSS keyframes as mismatched parentheses
Summary: prepare-Changelog treats CSS keyframes as mismatched parentheses
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 125787
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-08 20:26 PST by Brian Burg
Modified: 2015-08-04 09:40 PDT (History)
5 users (show)

See Also:

Attachments
patch (1.54 KB, patch)
2013-12-16 06:43 PST, Gergő Balogh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2013-12-08 20:26:05 PST 
Test case which triggers warnings in get_selector_line_ranges_for_css:

@-webkit-keyframes blink-plus-icon {
    0% {
        opacity: 1;
    }

    50% {
        opacity: 0.3;
    }

    100% {
        opacity: 0;
    }
}
Comment 1 Gergő Balogh 2013-12-16 06:43:38 PST 
Created attachment 219311 [details]
patch
Comment 2 WebKit Commit Bot 2013-12-16 09:55:06 PST 
Comment on attachment 219311 [details]
patch

Clearing flags on attachment: 219311

Committed r160645: <http://trac.webkit.org/changeset/160645>
Comment 3 WebKit Commit Bot 2013-12-16 09:55:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2013-12-16 10:54:50 PST 
(In reply to comment #4)
> This may have broken a unit test:
> http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/1538/steps/webkitperl-test/logs/stdio

It definitely does. Reverting this change fixes the test.
Comment 6 WebKit Commit Bot 2013-12-16 10:56:00 PST 
Re-opened since this is blocked by bug 125787