Bug 125434

Summary: check-webkit-style thinks that the super-constructor initialization needs "Comma should be at the beginning of the line in a member initialization list."
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: lvidacs.u-szeged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   

Description Filip Pizlo 2013-12-08 20:05:33 PST 
The following code:

class SSALoweringPhase : public Phase {
    static const bool verbose = false;
    
public:
    SSALoweringPhase(Graph& graph)
        : Phase(graph, "SSA lowering")
        , m_insertionSet(graph)
    {
    }

Causes check-webkit-style to claim that the ": Phase(graph, ..." line needs a comma.
Comment 1 Laszlo Vidacs 2013-12-18 01:58:17 PST 
Failed to reproduce the error. No error message issued with r160755, tried on the example code and on DFGSSALoweringPhase.cpp
Comment 2 Laszlo Vidacs 2014-03-21 03:41:31 PDT 
No error message in 166057.