Bug 125420

Summary: 32-bit MiniBrowser doesn't build
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit2Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Simon Fraser (smfr)
Reported 2013-12-08 11:02:07 PST
WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build. I guess we should just not build MiniBrowser for 32-bit? What if WTR wants to use WebKit2 API?
Attachments
Patch (2.04 KB, patch)
2013-12-08 20:46 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-12-08 11:02:27 PST
Also, this is breaking the build: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29
Sam Weinig
Comment 2 2013-12-08 20:46:07 PST
Created attachment 218723 [details] Patch
Sam Weinig
Comment 3 2013-12-08 20:48:13 PST
(In reply to comment #0) > WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build. > > I guess we should just not build MiniBrowser for 32-bit? I'm just going to fix the issue I introduced. But I am not sure there is value in building 32-bit. > What if WTR wants to use WebKit2 API? I don't think this is likely, at least anytime soon, since WTR is cross-platform.
Sam Weinig
Comment 4 2013-12-08 20:48:30 PST
Committed r160298: <http://trac.webkit.org/changeset/160298>
mitz
Comment 5 2013-12-08 20:51:20 PST
(In reply to comment #0) > WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build. > > I guess we should just not build MiniBrowser for 32-bit? What if WTR wants to use WebKit2 API? WebKitTestRunner is cross-platform so it’s not expected to need the Cocoa API. In the future, if we retire the cross-platform C SPI, we might want to transition WebKitTestRunner to some C++ SPI.
Note You need to log in before you can comment on or make changes to this bug.