Bug 125417

Summary: [GTK] Do not skip attributes with only custom setter
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gustavo, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 125416    
Bug Blocks:    
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2013-12-08 09:43:27 PST
We are currently skipping any argument having a custom setter or getter. In case of objects having a custom setter, we can generate the attribute as readonly and skip only the getter.
Attachments
Patch (18.61 KB, patch)
2013-12-08 09:49 PST, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-12-08 09:49:19 PST
Created attachment 218696 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-12-08 10:05:20 PST
Comment on attachment 218696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218696&action=review > Source/WebCore/ChangeLog:9 > + * bindings/gobject/GNUmakefile.am: Generate > + WebKitDOMMediaController that is now required by an attribute This could be a longer line =P > Source/WebCore/ChangeLog:11 > + * bindings/gobject/WebKitDOMCustom.cpp: Remove mothods that are now generated. *mothods > Source/WebCore/ChangeLog:16 > + (SkipAttribute): Do not skip attributes having a custom setter. Can you change the description to say we will now generate getters for properties that have custom setters? I was confused for a while.
Carlos Garcia Campos
Comment 3 2013-12-08 10:19:43 PST
Committed r160289: <http://trac.webkit.org/changeset/160289>
Note You need to log in before you can comment on or make changes to this bug.