Bug 125415

Summary:

[WK2] Guard include of SecItemShim.h with ENABLE(SEC_ITEM_SHIM)

Product:

WebKit

Reporter:

Brian Holt <brian.holt>

Component:

WebKit2

Assignee:

Brian Holt <brian.holt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, buildbot, commit-queue, mrobinson, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

118231

Attachments:

Description	Flags
Patch	none
Patch	none

Brian Holt

Reported 2013-12-08 08:01:33 PST

NetworkProcess.cpp and NetworkProcessProxy.cpp both include SecItemShim.h unguarded.

Attachments
Patch (2.20 KB, patch) 2013-12-08 08:13 PST, Brian Holt	no flags	Details Formatted Diff Diff
Patch (2.21 KB, patch) 2013-12-08 09:20 PST, Brian Holt	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brian Holt

Comment 1 2013-12-08 08:13:54 PST

Created attachment 218690 [details] Patch

Gustavo Noronha (kov)

Comment 2 2013-12-08 08:34:24 PST

Comment on attachment 218690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218690&action=review > Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:41 > -#include "SecItemShimProxy.h" > #include "WebContext.h" > #include "WebProcessMessages.h" > #include <wtf/RunLoop.h> > > +#if ENABLE(SEC_ITEM_SHIM) > +#include "SecItemShim.h" SecItemShim.h != SecItemShimProxy.h, intended?

Build Bot

Comment 3 2013-12-08 08:49:48 PST

Comment on attachment 218690 [details] Patch Attachment 218690 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46658037

Build Bot

Comment 4 2013-12-08 09:05:08 PST

Comment on attachment 218690 [details] Patch Attachment 218690 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46658040

Brian Holt

Comment 5 2013-12-08 09:20:11 PST

Created attachment 218693 [details] Patch

Brian Holt

Comment 6 2013-12-08 09:45:53 PST

Comment on attachment 218693 [details] Patch Thanks for the review - could you set CQ+?