Bug 125403

Summary: [Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKObject wrapping
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Sam Weinig 2013-12-07 21:11:56 PST 
[Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKObject wrapping
Comment 1 Sam Weinig 2013-12-07 21:12:23 PST 
Created attachment 218675 [details]
Patch
Comment 2 mitz 2013-12-07 21:18:19 PST 
Comment on attachment 218675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218675&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:89
> +- (id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInstance bundle:(InjectedBundle&)bundle

Can you add a space before the < while you’re here?

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:35
> +- (id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInstance bundle:(WebKit::InjectedBundle&)bundle;

Ditto.
Comment 3 Sam Weinig 2013-12-07 21:19:03 PST 
Committed r160277: <http://trac.webkit.org/changeset/160277>