Bug 125374
| Summary: | check-webkit-style shouldn't check indent of #define directives within initializer lists | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | llango.u-szeged, mmaxfield |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brian Burg
Test case where it spuriously complains about indentation:
RenderFileUploadControl::RenderFileUploadControl(HTMLInputElement& input, PassRef<RenderStyle> style)
: RenderBlockFlow(input, std::move(style))
#if ENABLE(DRAG_SUPPORT)
, m_canReceiveDroppedFiles(input.canReceiveDroppedFiles())
#endif
{
}
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brian Burg
It appears I was using an old version of the style checker, as I can't reproduce on my other machine and the relevant test cases in cpp_unittest.py seem to pass.