Bug 125364

Summary: check-webkit-style should understand --git-index
Product: WebKit Reporter: Brian Burg <burg>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, lforschler, mark.lam, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adding --git-index option none

Brian Burg
Reported 2013-12-06 13:40:41 PST
prepare-Changelog can figure out how to only consider things in the git index (i.e., git diff --cached). check-webkit-style should support this option as well. It is useful for splitting changes into smaller patches. I think this was also suggested here, in the context of bigger changes: https://bugs.webkit.org/show_bug.cgi?id=35781
Attachments
Adding --git-index option (8.08 KB, patch)
2014-04-23 04:11 PDT, Berta József 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Berta József
Comment 1 2014-04-23 04:11:55 PDT
Created attachment 229974 [details] Adding --git-index option
WebKit Commit Bot
Comment 2 2014-04-29 03:20:05 PDT
Comment on attachment 229974 [details] Adding --git-index option Clearing flags on attachment: 229974 Committed r167926: <http://trac.webkit.org/changeset/167926>
WebKit Commit Bot
Comment 3 2014-04-29 03:20:08 PDT
All reviewed patches have been landed. Closing bug.
Mark Lam
Comment 4 2014-04-29 11:31:19 PDT
This patch broke the Tools/Scripts/check-webkit-style script when run on a svn checkout. For example: $ ./Tools/Scripts/check-webkit-style Traceback (most recent call last): File "./Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 152, in main patch = host.scm().create_patch(options.git_commit, changed_files=changed_files, git_index=options.git_index) TypeError: create_patch() got an unexpected keyword argument 'git_index'
Lucas Forschler
Comment 5 2014-04-29 14:47:38 PDT
I think this can be fixed by adding a simple git_index=None argument to the create_patch function in checkout/scm/svn.py
Lucas Forschler
Comment 6 2014-04-29 14:58:45 PDT
Follow-up in 167957.
Note You need to log in before you can comment on or make changes to this bug.