| Summary: | Strip out extraneous logging from AppleGVA in media tests. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, glenn | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2013-12-06 11:40:16 PST
Created attachment 218608 [details]
Patch
Comment on attachment 218608 [details] Patch Cool. Please also roll out r160233 with this. Comment on attachment 218608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218608&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:294 > + test_input.is_media_test = self._port.is_media_test(test_input) I don't think this logging filtering needs to be restricted to media tests. > Tools/Scripts/webkitpy/port/driver.py:81 > + strip_media_logging_patterns.append((re.compile('AVF info:.*\n'), '')) > + strip_media_logging_patterns.append((re.compile('GVA info:.*\n'), '')) You could fold these two regexps together. I think these regexps should go into a platform-specific python file, since it's platform logging that you're filtering. Created attachment 218616 [details]
Patch
Created attachment 218617 [details]
Patch
Added a FIXME, as suggested by bdash over IRC.
Comment on attachment 218617 [details] Patch Attachment 218617 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/45808111 Committed r160247: <http://trac.webkit.org/changeset/160247> *** Bug 125356 has been marked as a duplicate of this bug. *** |