Bug 125357

Summary: Strip out extraneous logging from AppleGVA in media tests.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch simon.fraser: review+, buildbot: commit-queue-

Jer Noble
Reported 2013-12-06 11:40:16 PST
Strip out extraneous logging from AppleGVA in media tests.
Attachments
Patch (5.32 KB, patch)
2013-12-06 11:44 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (7.26 KB, patch)
2013-12-06 13:22 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (7.33 KB, patch)
2013-12-06 13:23 PST, Jer Noble 		simon.fraser: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-12-06 11:44:57 PST
Created attachment 218608 [details] Patch
Alexey Proskuryakov
Comment 2 2013-12-06 11:48:10 PST
Comment on attachment 218608 [details] Patch Cool. Please also roll out r160233 with this.
Simon Fraser (smfr)
Comment 3 2013-12-06 11:52:29 PST
Comment on attachment 218608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218608&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:294 > + test_input.is_media_test = self._port.is_media_test(test_input) I don't think this logging filtering needs to be restricted to media tests. > Tools/Scripts/webkitpy/port/driver.py:81 > + strip_media_logging_patterns.append((re.compile('AVF info:.*\n'), '')) > + strip_media_logging_patterns.append((re.compile('GVA info:.*\n'), '')) You could fold these two regexps together. I think these regexps should go into a platform-specific python file, since it's platform logging that you're filtering.
Jer Noble
Comment 4 2013-12-06 13:22:41 PST
Created attachment 218616 [details] Patch
Jer Noble
Comment 5 2013-12-06 13:23:58 PST
Created attachment 218617 [details] Patch Added a FIXME, as suggested by bdash over IRC.
Build Bot
Comment 6 2013-12-06 14:07:16 PST
Comment on attachment 218617 [details] Patch Attachment 218617 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/45808111
Jer Noble
Comment 7 2013-12-06 14:19:28 PST
Committed r160247: <http://trac.webkit.org/changeset/160247>
Alexey Proskuryakov
Comment 8 2014-07-17 10:29:25 PDT
*** Bug 125356 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.