Bug 125351

Summary:

Clean up the includes of RenderBlock.h

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

WebCore Misc.

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch - updated changelog	none
Patch - updated changelog	none

Description Zoltan Horvath 2013-12-06 09:39:24 PST

I changed some headers to forward declaration, and I removed/moved out some includes, which don't really belong to RenderBlock.h anymore.

Comment 1 Zoltan Horvath 2013-12-06 09:49:06 PST

Created attachment 218601 [details]
Patch

Comment 2 Zoltan Horvath 2013-12-06 09:55:47 PST

Created attachment 218602 [details]
Patch - updated changelog

Comment 3 Zoltan Horvath 2013-12-06 10:31:49 PST

Created attachment 218605 [details]
Patch - updated changelog

Comment 4 Darin Adler 2013-12-06 10:41:39 PST

Comment on attachment 218605 [details]
Patch - updated changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=218605&action=review

One small comment, but I’m going to do commit-queue+ anyway.

> Source/WebCore/rendering/RenderBlock.h:42
> +#if ENABLE(CSS_SHAPES)
> +class ShapeInsideInfo;
> +class ShapeValue;
> +#endif

I’m not sure we need to put forward declarations into #if statements. There is a small benefit (compile error if we use them by accident), but it looks ugly and the benefit is really small.

If we do keep the #if then better to add a blank line so it can be a separate “code paragraph”.

Comment 5 WebKit Commit Bot 2013-12-06 11:29:00 PST

Comment on attachment 218605 [details]
Patch - updated changelog

Clearing flags on attachment: 218605

Committed r160235: <http://trac.webkit.org/changeset/160235>

Comment 6 WebKit Commit Bot 2013-12-06 11:29:02 PST

All reviewed patches have been landed.  Closing bug.