| Summary: | Remove function from style/checkers/cpp.py | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tamas Gergely <tgergely.u-szeged> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cjerdonek, commit-queue, eric, galpeter, glenn | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tamas Gergely
2013-12-06 01:26:31 PST
Created attachment 218579 [details]
patch removes a function
I have simply split the functionality of process_file_data into two parts: the checker is now created directly in the CppStyleTestBase unit test, while setting the module's global _unit_test_config is done from the constructor of CppChecker.
Although currently it causes no problem, I think that setting the global from the constructor is not a nice nor safe solution. What could be done are:
- move the global into the CppChecker class and propagate its value (through 3 functions) to the only place it is used (the 3 functions are used nowhere else), or
- move all the functions (or almost all) into the CppChecker class, or
- leave it as it is now.
By the way, to set up some specific environments, the cpp_unittest uses both globals and parameter propagation. Is one of them preferred?
Comment on attachment 218579 [details] patch removes a function Clearing flags on attachment: 218579 Committed r160230: <http://trac.webkit.org/changeset/160230> All reviewed patches have been landed. Closing bug. |