| Summary: | [MSE] Add a runtime-setting for the MediaSource constructor. | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, darin, eric.carlson, esprehn+autocc, glenn, gtk-ews, kondapallykalyan, rego+ews, rniwa, xan.lopez | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Jer Noble
2013-12-05 23:28:03 PST
Created attachment 218573 [details]
Patch
Comment on attachment 218573 [details] Patch Attachment 218573 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/45308036 New failing tests: js/dom/global-constructors-attributes.html js/dom/JSON-parse.html media/media-source/media-source-append-buffer.html media/media-source/media-source-closed.html media/media-source/media-source-fastseek.html media/media-source/media-source-canplaythrough.html media/media-source/media-source-tracks.html media/media-source/media-source-append-failed.html media/media-source/media-source-track-enabled.html media/media-source/media-source-addsourcebuffer.html media/media-source/media-source-play.html Created attachment 218583 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 218573 [details] Patch Attachment 218573 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/45408006 New failing tests: js/dom/global-constructors-attributes.html media/media-source/media-source-append-buffer.html media/media-source/media-source-closed.html media/media-source/media-source-fastseek.html media/media-source/media-source-canplaythrough.html media/media-source/media-source-tracks.html media/media-source/media-source-append-failed.html media/media-source/media-source-track-enabled.html media/media-source/media-source-addsourcebuffer.html media/media-source/media-source-play.html Created attachment 218587 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 218573 [details] Patch Attachment 218573 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/45098033 New failing tests: js/dom/global-constructors-attributes.html js/dom/JSON-parse.html media/media-source/media-source-append-buffer.html media/media-source/media-source-closed.html media/media-source/media-source-fastseek.html media/media-source/media-source-canplaythrough.html media/media-source/media-source-tracks.html media/media-source/media-source-append-failed.html media/media-source/media-source-track-enabled.html media/media-source/media-source-addsourcebuffer.html media/media-source/media-source-play.html Created attachment 218588 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 218573 [details] Patch Attachment 218573 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/44638040 New failing tests: js/dom/global-constructors-attributes.html js/dom/JSON-parse.html media/media-source/media-source-append-buffer.html media/media-source/media-source-closed.html media/media-source/media-source-fastseek.html media/media-source/media-source-canplaythrough.html media/media-source/media-source-tracks.html media/media-source/media-source-append-failed.html media/media-source/media-source-track-enabled.html media/media-source/media-source-addsourcebuffer.html media/media-source/media-source-play.html Created attachment 218590 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 218598 [details]
Patch
Enable the MSE setting when installing the mock media engine.
Comment on attachment 218598 [details] Patch Attachment 218598 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/45838043 Created attachment 218600 [details]
Patch
A different approach: Enable MediaSource in DRT and WKTR by default.
(In reply to comment #0) > [MSE] Add a runtime-setting for the MediaSource constructor. Rationale? (In reply to comment #13) > (In reply to comment #0) > > [MSE] Add a runtime-setting for the MediaSource constructor. > > Rationale? YouTube will preferentially use MSE if the MediaSource API is present. Disabling it at runtime allows us to bring up MSE without breaking YouTube. This came up because of: <rdar://problem/15587450>. Comment on attachment 218600 [details]
Patch
Looks good to me (or should I say LGTM) but you may want to check with Darin.
(In reply to comment #15) > (From update of attachment 218600 [details]) > Looks good to me (or should I say LGTM) but you may want to check with Darin. Given that it fixes a pretty big bug with YouTube, I'll check it in now, and roll-out if Darin objects. :) Committed r160261: <http://trac.webkit.org/changeset/160261> |