| Summary: | [Gtk] install-dependencies doesn't install libgtk-3-dev | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brendan Long <b.long> | ||||
| Component: | Tools / Tests | Assignee: | Brendan Long <b.long> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Minor | CC: | commit-queue, gustavo, mrobinson, zan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Brendan Long
2013-12-05 15:08:12 PST
Apparently it's also missing libsoup2.4-dev and libgtk2.0-dev. I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance. As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only. (In reply to comment #2) > I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance. > > As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only. Yeah, presumably if you are using install-dependencies you are also using build-webkit. Created attachment 218680 [details]
Patch
I also added a section for webkit-patch dependencies, since it needs subversion apparently.
Comment on attachment 218680 [details] Patch Clearing flags on attachment: 218680 Committed r160285: <http://trac.webkit.org/changeset/160285> All reviewed patches have been landed. Closing bug. |