| Summary: | Code refactor: process_clean_line at cpp style checker can be simplified | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daker Fernandes Pinheiro <daker.pinheiro> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, commit-queue, daker.pinheiro, glenn, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Daker Fernandes Pinheiro
2013-12-05 14:04:12 PST
Created attachment 218542 [details]
Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
Attachment 218542 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'Source/WebCore/ChangeLog', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:26: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebCore/ChangeLog:60: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebCore/ChangeLog:90: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 3 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 218542 [details]
Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
I'm sure it is an accidentally uploaded file. Could you upload the real fix?
Created attachment 218563 [details]
Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
Comment on attachment 218563 [details] Remove excessive nesting from _EnumState.process_clean_line at cpp style checker Clearing flags on attachment: 218563 Committed r171039: <http://trac.webkit.org/changeset/171039> All reviewed patches have been landed. Closing bug. |