RESOLVED FIXED 125317
Code refactor: process_clean_line at cpp style checker can be simplified 
https://bugs.webkit.org/show_bug.cgi?id=125317
Summary Code refactor: process_clean_line at cpp style checker can be simplified
Daker Fernandes Pinheiro
Reported 2013-12-05 14:04:12 PST
There is excessive nesting in this particular method.
Attachments
Remove excessive nesting from _EnumState.process_clean_line at cpp style checker (5.05 KB, patch)
2013-12-05 14:10 PST, Daker Fernandes Pinheiro 		ossy: review-
DetailsFormatted DiffDiff
Remove excessive nesting from _EnumState.process_clean_line at cpp style checker (2.95 KB, patch)
2013-12-05 19:25 PST, Daker Fernandes Pinheiro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daker Fernandes Pinheiro
Comment 1 2013-12-05 14:10:18 PST
Created attachment 218542 [details] Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
WebKit Commit Bot
Comment 2 2013-12-05 14:12:34 PST
Attachment 218542 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'Source/WebCore/ChangeLog', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/ChangeLog:26: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/ChangeLog:60: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/ChangeLog:90: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 3 2013-12-05 14:28:58 PST
Comment on attachment 218542 [details] Remove excessive nesting from _EnumState.process_clean_line at cpp style checker I'm sure it is an accidentally uploaded file. Could you upload the real fix?
Daker Fernandes Pinheiro
Comment 4 2013-12-05 19:25:37 PST
Created attachment 218563 [details] Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
WebKit Commit Bot
Comment 5 2014-07-12 17:54:37 PDT
Comment on attachment 218563 [details] Remove excessive nesting from _EnumState.process_clean_line at cpp style checker Clearing flags on attachment: 218563 Committed r171039: <http://trac.webkit.org/changeset/171039>
WebKit Commit Bot
Comment 6 2014-07-12 17:54:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.