Summary: | [GStreamer] Audio/Video sink management is incoherent | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, gustavo, jer.noble, menard, mrobinson, pnormand | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2013-12-05 06:31:57 PST
Created attachment 218521 [details]
patch
Comment on attachment 218521 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=218521&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:505 > +GstElement* MediaPlayerPrivateGStreamerBase::videoSink() const > +{ > + return m_fpsSink ? m_fpsSink.get() : m_webkitVideoSink.get(); > +} This looks unused, will be used in a follow-up patch I guess? Well I added it for consistency mainly, it's indeed unused. I guess I'll remove it till one day its existence can no longer be avoided :) Committed r160214: <http://trac.webkit.org/changeset/160214> |