Bug 125304

Summary: [GStreamer] Audio/Video sink management is incoherent
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, gustavo, jer.noble, menard, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch gustavo: review+

Philippe Normand
Reported 2013-12-05 06:31:57 PST
The API in the base class to configure the sinks is incoherent, a video-sink accessor is also missing.
Attachments
patch (9.14 KB, patch)
2013-12-05 10:10 PST, Philippe Normand 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2013-12-05 10:10:42 PST
Created attachment 218521 [details] patch
Gustavo Noronha (kov)
Comment 2 2013-12-05 10:50:56 PST
Comment on attachment 218521 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=218521&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:505 > +GstElement* MediaPlayerPrivateGStreamerBase::videoSink() const > +{ > + return m_fpsSink ? m_fpsSink.get() : m_webkitVideoSink.get(); > +} This looks unused, will be used in a follow-up patch I guess?
Philippe Normand
Comment 3 2013-12-06 00:33:36 PST
Well I added it for consistency mainly, it's indeed unused. I guess I'll remove it till one day its existence can no longer be avoided :)
Philippe Normand
Comment 4 2013-12-06 01:04:08 PST
Committed r160214: <http://trac.webkit.org/changeset/160214>
Note You need to log in before you can comment on or make changes to this bug.