Bug 125269

Summary: [MSE][Mac] Crash when removing MediaSource from HTMLMediaElement.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125270    
Attachments:
Description Flags
Patch
none
Patch sam: review+

Jer Noble
Reported 2013-12-04 17:34:53 PST
[MSE][Mac] Crash when removing MediaSource from HTMLMediaElement.
Attachments
Patch (9.26 KB, patch)
2013-12-04 17:41 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (13.50 KB, patch)
2013-12-07 16:41 PST, Jer Noble 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-12-04 17:41:15 PST
Created attachment 218474 [details] Patch
Jer Noble
Comment 2 2013-12-07 16:41:41 PST
Created attachment 218670 [details] Patch
Sam Weinig
Comment 3 2013-12-07 17:35:54 PST
Comment on attachment 218670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218670&action=review Test case? > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:62 > + void clearMediaSource() { m_mediaSource = 0; } nullptr?
Jer Noble
Comment 4 2013-12-07 22:18:37 PST
(In reply to comment #3) > (From update of attachment 218670 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218670&action=review > > Test case? The crash only (reliably) happens with MallocScribble enabled. But when it is enabled, an existing test crashes. > > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:62 > > + void clearMediaSource() { m_mediaSource = 0; } > > nullptr? Will change.
Jer Noble
Comment 5 2013-12-07 22:37:04 PST
Committed r160281: <http://trac.webkit.org/changeset/160281>
Simon Fraser (smfr)
Comment 6 2013-12-08 10:09:01 PST
Could this have caused two tests to show malloc errors? http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r160286%20(853)/results.html
Jer Noble
Comment 7 2013-12-09 08:20:26 PST
(In reply to comment #6) > Could this have caused two tests to show malloc errors? > http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r160286%20(853)/results.html It's unlikely; those test cases should never hit MSE code. But i'll check.
Note You need to log in before you can comment on or make changes to this bug.