Summary: | Add a loading property to WKBrowsingContextController | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2013-12-04 14:32:57 PST
Created attachment 218450 [details]
Patch
Attachment 218450 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/PageLoadState.cpp', u'Source/WebKit2/UIProcess/PageLoadState.h', u'Tools/ChangeLog', u'Tools/MiniBrowser/mac/WK2BrowserWindowController.m', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:109: Missing spaces around = [whitespace/operators] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 218450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218450&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:109 > +@property (nonatomic, readonly, getter=isLoading) BOOL loading; I think “nonatomic” is meaningless here. > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm:84 > + No need for this line. Committed r160129: <http://trac.webkit.org/changeset/160129> |