Summary: | [EFL][GTK][WK2] Remove unnecessary reinterpret_casts when setting API clients | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nick Diego Yamane (diegoyam) <nick.diego> | ||||||||
Component: | WebKit2 | Assignee: | Nick Diego Yamane (diegoyam) <nick.diego> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, gyuyoung.kim, mrobinson, ossy, rakuco | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 125240 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Nick Diego Yamane (diegoyam)
2013-12-04 10:54:49 PST
Created attachment 218425 [details]
Patch
Created attachment 218426 [details]
Rebased patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 218426 [details] Rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=218426&action=review Looks good apart from the ChangeLog weirdness. > Source/WebKit2/ChangeLog:72 > + * UIProcess/API/gtk/WebKitFullscreenClient.cpp: > + (attachFullScreenClientToView): > + * UIProcess/API/gtk/WebKitRequestManagerClient.cpp: > + (attachRequestManagerClientToContext): > + * UIProcess/API/gtk/WebKitTextChecker.cpp: > + (WebKitTextChecker::WebKitTextChecker): > + * UIProcess/API/gtk/WebKitWebInspector.cpp: > + (webkitWebInspectorCreate): > + * UIProcess/efl/BatteryProvider.cpp: > + (BatteryProvider::BatteryProvider): > + * UIProcess/efl/NetworkInfoProvider.cpp: > + (NetworkInfoProvider::NetworkInfoProvider): > + * UIProcess/efl/RequestManagerClientEfl.cpp: > + (WebKit::RequestManagerClientEfl::RequestManagerClientEfl): > + * UIProcess/efl/TextCheckerClientEfl.cpp: > + (TextCheckerClientEfl::TextCheckerClientEfl): > + * UIProcess/efl/VibrationClientEfl.cpp: > + (VibrationClientEfl::VibrationClientEfl): > + * UIProcess/efl/ViewClientEfl.cpp: It seems wrong to update an old ChangeLog entry. (In reply to comment #4) > (From update of attachment 218426 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218426&action=review > > Looks good apart from the ChangeLog weirdness. > > > Source/WebKit2/ChangeLog:72 > > + * UIProcess/API/gtk/WebKitFullscreenClient.cpp: > > + (attachFullScreenClientToView): > > + * UIProcess/API/gtk/WebKitRequestManagerClient.cpp: > > + (attachRequestManagerClientToContext): > > + * UIProcess/API/gtk/WebKitTextChecker.cpp: > > + (WebKitTextChecker::WebKitTextChecker): > > + * UIProcess/API/gtk/WebKitWebInspector.cpp: > > + (webkitWebInspectorCreate): > > + * UIProcess/efl/BatteryProvider.cpp: > > + (BatteryProvider::BatteryProvider): > > + * UIProcess/efl/NetworkInfoProvider.cpp: > > + (NetworkInfoProvider::NetworkInfoProvider): > > + * UIProcess/efl/RequestManagerClientEfl.cpp: > > + (WebKit::RequestManagerClientEfl::RequestManagerClientEfl): > > + * UIProcess/efl/TextCheckerClientEfl.cpp: > > + (TextCheckerClientEfl::TextCheckerClientEfl): > > + * UIProcess/efl/VibrationClientEfl.cpp: > > + (VibrationClientEfl::VibrationClientEfl): > > + * UIProcess/efl/ViewClientEfl.cpp: > > It seems wrong to update an old ChangeLog entry. Oops, maybe the git rebase has done this :( I'll fix that. But it looks like there are other build issues, probably result from r160104. I'll try to fix that firstly. Created attachment 218447 [details]
Patch
Comment on attachment 218447 [details] Patch Clearing flags on attachment: 218447 Committed r160128: <http://trac.webkit.org/changeset/160128> All reviewed patches have been landed. Closing bug. |