Bug 125221

Summary:

contentWindow.location.assign() method not throwing SyntaxError when used without argument

Product:

WebKit

Reporter:

Lukasz Krok <l.krok>

Component:

DOM

Assignee:

Lukasz Krok <l.krok>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ap, buildbot, cdumez, mpakulavelrutka, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	beidson: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none

Lukasz Krok

Reported 2013-12-04 06:43:20 PST

According to w3c specification if the resolving step of the assign() method is not successful, then the user agent must instead throw a SyntaxError exception

Attachments
Proposed patch (6.10 KB, patch) 2013-12-10 06:19 PST, Lukasz Krok	beidson: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (584.14 KB, application/zip) 2013-12-10 07:05 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (319.34 KB, application/zip) 2013-12-10 10:13 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Lukasz Krok

Comment 1 2013-12-10 06:19:58 PST

Created attachment 218863 [details] Proposed patch

Build Bot

Comment 2 2013-12-10 07:05:33 PST

Comment on attachment 218863 [details] Proposed patch Attachment 218863 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47678032 New failing tests: fast/dom/Window/invalid-protocol.html canvas/philip/tests/2d.missingargs.html fast/dom/HTMLElement/class-list-quirks.html fast/canvas/gradient-addColorStop-with-invalid-color.html canvas/philip/tests/2d.pattern.repeat.unrecognised.html fast/css/css3-nth-tokens-script.html fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml fast/canvas/canvas-pattern-behaviour.html canvas/philip/tests/2d.pattern.repeat.undefined.html fast/dom/HTMLElement/insertAdjacentHTML-errors.html fast/dom/dataset-xhtml.xhtml canvas/philip/tests/2d.gradient.object.invalidcolour.html fast/dom/MutationObserver/observe-exceptions.html fast/dom/SelectorAPI/dumpNodeList.html fast/dom/css-mediarule-functions.html canvas/philip/tests/2d.pattern.repeat.nullsuffix.html fast/dom/Window/custom-constructors.html fast/dom/HTMLOutputElement/dom-settable-token-list.html canvas/philip/tests/2d.pattern.repeat.case.html fast/dom/HTMLElement/set-invalid-value.html fast/dom/element-attribute-js-null.html fast/media/mq-js-media-except-02.html fast/canvas/canvas-gradient-addStop-error.html fast/dynamic/insertAdjacentHTML.html fast/dom/SelectorAPI/dumpNodeList-almost-strict.html fast/dom/HTMLElement/class-list.html fast/eventsource/eventsource-constructor.html css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html fast/innerHTML/innerHTML-changing-document-properties.xhtml fast/dom/dataset.html

Build Bot

Comment 3 2013-12-10 07:05:36 PST

Created attachment 218869 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2013-12-10 10:13:10 PST

Comment on attachment 218863 [details] Proposed patch Attachment 218863 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46588185 New failing tests: editing/unsupported-content/list-type-before.html canvas/philip/tests/2d.missingargs.html editing/unsupported-content/table-type-before.html fast/canvas/gradient-addColorStop-with-invalid-color.html canvas/philip/tests/2d.pattern.repeat.unrecognised.html fast/css/css3-nth-tokens-script.html fast/canvas/canvas-pattern-behaviour.html canvas/philip/tests/2d.pattern.repeat.undefined.html fast/dom/HTMLElement/insertAdjacentHTML-errors.html fast/dom/dataset-xhtml.xhtml canvas/philip/tests/2d.gradient.object.invalidcolour.html fast/dom/MutationObserver/observe-exceptions.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/list-delete-001.html fast/dom/SelectorAPI/dumpNodeList.html fast/dom/css-mediarule-functions.html canvas/philip/tests/2d.pattern.repeat.nullsuffix.html fast/dom/Window/custom-constructors.html fast/dom/HTMLOutputElement/dom-settable-token-list.html canvas/philip/tests/2d.pattern.repeat.case.html fast/dom/HTMLElement/set-invalid-value.html fast/dom/element-attribute-js-null.html fast/dom/HTMLElement/class-list-quirks.html fast/dom/SelectorAPI/dumpNodeList-almost-strict.html editing/unsupported-content/table-type-after.html fast/dom/HTMLElement/class-list.html editing/unsupported-content/list-delete-003.html editing/unsupported-content/list-type-after.html css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html fast/dom/dataset.html

Build Bot

Comment 5 2013-12-10 10:13:12 PST

Created attachment 218880 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Brady Eidson

Comment 6 2016-05-24 22:05:39 PDT

Comment on attachment 218863 [details] Proposed patch Assuming that patches for review since 2013 are stale, r-

Chris Dumez

Comment 7 2016-05-24 22:07:42 PDT

*** This bug has been marked as a duplicate of bug 154357 ***

Note You need to log in before you can comment on or make changes to this bug.