Bug 125208

Summary:

bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, commit-queue, esprehn+autocc, gyuyoung.kim, kling, koivisto

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Removes the member functions	none

Ryosuke Niwa

Reported 2013-12-03 20:49:07 PST

Merge https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf No one should ever use the vlink/link/text/alink and other color attribute methods on HTMLBodyElement in C++ code, and the bindings for HTMLBodyElement are set to Reflect so they never go through these methods anyway. They only existed to support the code in HTMLDocument.cpp. Instead we can contain all the logic there and also simplify these methods greatly letting us delete a bunch of code.

Attachments
Removes the member functions (10.21 KB, patch) 2013-12-03 20:53 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-12-03 20:53:07 PST

Created attachment 218380 [details] Removes the member functions

WebKit Commit Bot

Comment 2 2013-12-03 23:41:53 PST

Comment on attachment 218380 [details] Removes the member functions Clearing flags on attachment: 218380 Committed r160072: <http://trac.webkit.org/changeset/160072>

WebKit Commit Bot

Comment 3 2013-12-03 23:41:55 PST

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 4 2013-12-04 11:52:35 PST

Comment on attachment 218380 [details] Removes the member functions View in context: https://bugs.webkit.org/attachment.cgi?id=218380&action=review > Source/WebCore/html/HTMLDocument.cpp:166 > + return bodyElement->getAttribute(bgcolorAttr); Could be fastGetAttribute. > Source/WebCore/html/HTMLDocument.cpp:182 > + return bodyElement->getAttribute(textAttr); Could be fastGetAttribute. > Source/WebCore/html/HTMLDocument.cpp:198 > + return bodyElement->getAttribute(alinkAttr); Could be fastGetAttribute. > Source/WebCore/html/HTMLDocument.cpp:214 > + return bodyElement->getAttribute(linkAttr); Could be fastGetAttribute. > Source/WebCore/html/HTMLDocument.cpp:230 > + return bodyElement->getAttribute(vlinkAttr); Could be fastGetAttribute.

Ryosuke Niwa

Comment 5 2013-12-04 19:54:17 PST

Committed r160157: <http://trac.webkit.org/changeset/160157>

Note You need to log in before you can comment on or make changes to this bug.