Bug 125206

Summary: [EFL][WK2] Fix build after API::Client changes
Product: WebKit Reporter: Nick Diego Yamane (diegoyam) <nick.diego>
Component: WebKit EFLAssignee: Nick Diego Yamane (diegoyam) <nick.diego>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, cgarcia, cmarcelo, commit-queue, gustavo, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, luiz, mrobinson, noam, ossy, rakuco, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 125182    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Nick Diego Yamane (diegoyam)
Reported 2013-12-03 18:53:21 PST
Bug 125129 changed the way WK2 API::ClientTraits are implemented, to use a template-based approach. After that EFL WK2 build is broken. To fix that we should make modifications similar to what is being done in bug 125129 and bug 125182.
Attachments
Patch (81.49 KB, patch)
2013-12-03 20:37 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-12-03 20:37:34 PST
Created attachment 218379 [details] Patch EFL changes including the changes from bug 125182, which this bug depends on. Initially to see the buildbot results.
WebKit Commit Bot
Comment 2 2013-12-03 20:39:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Csaba Osztrogonác
Comment 3 2013-12-04 00:46:00 PST
Comment on attachment 218379 [details] Patch I'm not 100% sure if it is the proper change. But we don't know anything about the original change and its author and WK2 owners are unreachable. :(( So r=me to fix the build as soon as possible. We can always revise the patch later if we get feedback from WK2 owners.
Csaba Osztrogonác
Comment 4 2013-12-04 00:55:58 PST
landed in http://trac.webkit.org/changeset/160075
Gustavo Noronha (kov)
Comment 5 2013-12-04 02:56:27 PST
*** Bug 125182 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.