Bug 125183

Summary: [Cocoa] Give two load delegate methods more conventional names
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Rename load error delegate methods andersca: review+

Description mitz 2013-12-03 14:15:35 PST
[Cocoa] Give two load delegate methods more conventional names
Comment 1 mitz 2013-12-03 14:17:44 PST
Created attachment 218340 [details]
Rename load error delegate methods
Comment 2 mitz 2013-12-03 14:29:46 PST
Committed <http://trac.webkit.org/r160040>.
Comment 3 Simon Fraser (smfr) 2013-12-03 22:42:17 PST
This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out:
http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100
Comment 4 mitz 2013-12-03 22:44:04 PST
(In reply to comment #3)
> This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out:
> http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100

I must have missed the fact that the test uses a renamed method. I’ll update it.
Comment 5 mitz 2013-12-03 22:48:14 PST
(In reply to comment #4)
> (In reply to comment #3)
> > This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out:
> > http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100
> 
> I must have missed the fact that the test uses a renamed method. I’ll update it.

Committed <http://trac.webkit.org/r160071>.