Bug 125179 – [Win] Support 64-bit Application Support Libraries Location

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

Currently we don't expect WebKit users on Windows to be working with 64-bit builds. Our test infrastructure needs a way to support 32-bit and 64-bit runtimes so that we can develop and test these configurations.

For now, use an environment variable WEBKIT_64_SUPPORT to specify the path to 64-bit versions of libxml2.dll, libxslt.dll, etc.  In the future, these will be available someplace like "C:\Program Files\..." and we can remove this code.

[Brent Fulgham]

Created attachment 218333 [details]
Patch

[Tim Horton]

Comment on attachment 218333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218333&action=review

> Tools/ChangeLog:10
> +        to speficy these locations.

specify

> Tools/Scripts/webkitdirs.pm:1577
> +    # FIXME: Remove the following in https://webkit.org/b/125180

maybe these should say "FIXME (125180): Remove this temporary workaround" or something. Not sure the style.

> Tools/Scripts/webkitdirs.pm:1614
> +    print "WEBKIT_64_SUPPORT is set to: ", $ENV{"WEBKIT_64_SUPPORT"}, "\n" if isWin64(); #FIXME: Remove in https://webkit.org/b/125180

space after #

> Tools/Scripts/webkitdirs.pm:2128
> +        return $ENV{"WEBKIT_64_SUPPORT"}, "\n" if isWin64(); #FIXME: Remove in https://webkit.org/b/125180

space after #

[Brent Fulgham]

Committed r160035: <http://trac.webkit.org/changeset/160035>