Bug 125163

Summary:

[CSS Shapes] Remove explicit numbering from BasicShape::Type and CSSBasicShape::Type enums

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

CSS

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

98664, 89256

Attachments:

Description	Flags
proposed patch	none

Description Zoltan Horvath 2013-12-03 10:15:28 PST

I don't see any reason to have explicit numbering for the Type enum in our [CSS]BasicShape classes. I removed numbering, which will decrease the merge conflicts on Type changes.

Comment 1 Zoltan Horvath 2013-12-03 10:17:57 PST

Created attachment 218301 [details]
proposed patch

Comment 2 Rob Buis 2013-12-04 13:41:18 PST

Comment on attachment 218301 [details]
proposed patch

LGTM.

Comment 3 WebKit Commit Bot 2013-12-04 14:16:03 PST

Comment on attachment 218301 [details]
proposed patch

Clearing flags on attachment: 218301

Committed r160126: <http://trac.webkit.org/changeset/160126>

Comment 4 WebKit Commit Bot 2013-12-04 14:16:05 PST

All reviewed patches have been landed.  Closing bug.