Bug 125077

Summary:

simplify MediaPlayerPrivateGStreamerBase::createVideoSink()

Product:

WebKit

Reporter:

Víctor M. Jáquez L. <vjaquez>

Component:

WebKit Misc.

Assignee:

Víctor M. Jáquez L. <vjaquez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, gustavo, jer.noble, menard, mrobinson, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Víctor M. Jáquez L. 2013-12-02 08:56:06 PST

* Remove the unused parameter
* Remove the GStreamer 0.10.22 run-time validation, since we are using GStreamer 1.0 officially.
* Remove the creation of a spurious Bin for the video sink, since either the fpssink or the webkitsink are valid elements.

Comment 1 Víctor M. Jáquez L. 2013-12-02 09:02:39 PST

Created attachment 218176 [details]
Patch

Comment 2 Philippe Normand 2013-12-02 09:06:39 PST

Comment on attachment 218176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218176&action=review

Noice clean-up!

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:495
> +        m_videoSinkBin = m_webkitVideoSink;

Perhaps this member can be renamed and/or dropped?

Comment 3 Víctor M. Jáquez L. 2013-12-02 10:36:41 PST

Created attachment 218184 [details]
Patch

Comment 4 WebKit Commit Bot 2013-12-02 11:52:47 PST

Comment on attachment 218184 [details]
Patch

Clearing flags on attachment: 218184

Committed r159945: <http://trac.webkit.org/changeset/159945>

Comment 5 WebKit Commit Bot 2013-12-02 11:52:49 PST

All reviewed patches have been landed.  Closing bug.