Bug 125074

Summary: [GTK] Fails to build with freetype 2.5.1
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, cgarcia, commit-queue, d-r, eric.carlson, kenneth, mario, mrobinson, nick.diego, schenney, tony, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alberto Garcia
Reported 2013-12-02 05:05:55 PST
FreeType 2.5.1 changed the header file layout: http://sourceforge.net/projects/freetype/files/freetype2/2.5.1/ Now all headers went from /usr/include/freetype2/freetype/ to /usr/include/freetype2/. At least HarfBuzzFaceCairo.cpp looks for the headers in the old path so it doesn't build. This is apparently not the official way to include FreeType, as explained in the link above: "Applications that use [...] the documented way for header inclusion [...] don't need any change to the source code."
Attachments
Patch (3.02 KB, patch)
2013-12-02 08:48 PST, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andres Gomez Garcia
Comment 1 2013-12-02 05:06:48 PST
Giving it a look ...
Zan Dobersek
Comment 2 2013-12-02 06:08:13 PST
The GTK port relies on pkg-config to provide the correct inclusion directory, so I'm interested where this goes wrong.
Alberto Garcia
Comment 3 2013-12-02 06:25:59 PST
(In reply to comment #2) > The GTK port relies on pkg-config to provide the correct inclusion > directory, so I'm interested where this goes wrong. Apparently we're including the freetype headers in an unsupported way. We should use FT_FREETYPE_H, FT_TRUETYPE_TABLES_H, etc. I think Andrés is testing the changes and will upload a patch soon.
Andres Gomez Garcia
Comment 4 2013-12-02 07:56:20 PST
Confirmed after upgrading freetype6 jhbuild module to 2.5.1 and trying to build: CXX Source/WebCore/platform/graphics/freetype/libPlatform_la-SimpleFontDataFreeType.lo ../../Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:47:31: fatal error: freetype/tttables.h: No such file or directory compilation terminated. make[1]: *** [Source/WebCore/platform/graphics/freetype/libPlatform_la-SimpleFontDataFreeType.lo] Error 1 make[1]: Leaving directory `/opt/webkit/WebKit.git/WebKitBuild/Release' make: *** [all] Error 2
Andres Gomez Garcia
Comment 5 2013-12-02 08:48:39 PST
Created attachment 218175 [details] Patch
Alberto Garcia
Comment 6 2013-12-02 09:04:46 PST
(In reply to comment #5) > Created an attachment (id=218175) [details] > Patch lgtm
Carlos Garcia Campos
Comment 7 2013-12-02 09:21:14 PST
Comment on attachment 218175 [details] Patch I guess this affects the stable branch too.
Andres Gomez Garcia
Comment 8 2013-12-02 09:24:04 PST
(In reply to comment #7) > (From update of attachment 218175 [details]) > I guess this affects the stable branch too. Yes, I think it makes sense to cherry-pick it.
Alberto Garcia
Comment 9 2013-12-02 09:24:43 PST
(In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 218175 [details] [details]) > > I guess this affects the stable branch too. > > Yes, I think it makes sense to cherry-pick it. It does, I can reproduce it in Debian with freetype from sid.
WebKit Commit Bot
Comment 10 2013-12-02 09:46:22 PST
Comment on attachment 218175 [details] Patch Clearing flags on attachment: 218175 Committed r159939: <http://trac.webkit.org/changeset/159939>
WebKit Commit Bot
Comment 11 2013-12-02 09:46:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.