Bug 125063

Summary: Guard JIT include.
Product: WebKit Reporter: László Langó <llango.u-szeged>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

László Langó
Reported 2013-12-02 00:35:18 PST
JSInterfaceJIT.h is unused in LLIntThunks.cpp when webkit is built without JIT.
Attachments
Patch (1.13 KB, patch)
2013-12-02 00:39 PST, László Langó 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2013-12-03 05:07 PST, László Langó 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
László Langó
Comment 1 2013-12-02 00:39:46 PST
Created attachment 218147 [details] Patch
Michael Saboff
Comment 2 2013-12-02 08:27:50 PST
Comment on attachment 218147 [details] Patch The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points.
Filip Pizlo
Comment 3 2013-12-02 09:10:08 PST
(In reply to comment #2) > (From update of attachment 218147 [details]) > The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points. Does that make Lashlo's change wrong? I think that this change is technically correct but just leads to code that is more complicated than it needs to be. I think that the problem here is that: - We have separate ENABLE(JIT) and ENABLE(LLINT_C_LOOP) defines, even though the two are exactly mutually exclusive if ENABLE(LLINT). - This entire file should basically either be guarded with either ENABLE(LLINT) && ENABLE(JIT) or ENABLE(LLINT) && !ENALBE(LLINT_C_LOOP). Lashlo's change sort of accomplishes this, but it does so piecemeal - the whole file is guarded by ENABLE(LLINT), then an include is guarded by ENABLE(JIT), and the rest of the file is guarded by !ENABLE(LLINT_C_LOOP).
László Langó
Comment 4 2013-12-03 05:07:20 PST
Created attachment 218287 [details] Patch
WebKit Commit Bot
Comment 5 2013-12-03 07:50:43 PST
Comment on attachment 218287 [details] Patch Clearing flags on attachment: 218287 Committed r160003: <http://trac.webkit.org/changeset/160003>
WebKit Commit Bot
Comment 6 2013-12-03 07:50:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.