Bug 125051

Summary:

[Cocoa] The PageLoadState::Observer is not being set on iOS

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Sam Weinig 2013-12-01 17:47:25 PST

[Cocoa] The PageLoadState::Observer is not being set on iOS

Comment 1 Sam Weinig 2013-12-01 17:48:11 PST

Created attachment 218126 [details]
Patch

Comment 2 mitz 2013-12-01 17:49:20 PST

Comment on attachment 218126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218126&action=review

> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43
> +#if WK_API_ENABLED

Not sure we need these conditionals in iOS-only files.

Comment 3 Sam Weinig 2013-12-01 17:50:36 PST

(In reply to comment #2)
> (From update of attachment 218126 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218126&action=review
> 
> > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43
> > +#if WK_API_ENABLED
> 
> Not sure we need these conditionals in iOS-only files.

I'm going to keep it for consistency for now.

Comment 4 Sam Weinig 2013-12-01 17:50:51 PST

Committed r159906: <http://trac.webkit.org/changeset/159906>