Summary: | [EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, cmarcelo, commit-queue, gyuyoung.kim, lucas.de.marchi, luiz, noam, rakuco, zeno | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryuan Choi
2013-11-30 16:08:16 PST
Created attachment 218094 [details]
Patch
Comment on attachment 218094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:992 > + ewk_view_html_string_load(webView(), contentsSizeHTMLPortrait, 0, 0); Assuming that m_contentsSize needs to be initialized, this test looks make sense. > Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374 > + m_contentsSize = IntSize(); Noam, could you take a look this ? Comment on attachment 218094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review Some language nits, otherwise ok with me > Source/WebKit2/ChangeLog:9 > + takes care of newly loaded contents having same size with previous one. takes care -> would take care having -> with with -> as >> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374 >> + m_contentsSize = IntSize(); > > Noam, could you take a look this ? I think this is fine. Comment on attachment 218094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review Some language nits, otherwise ok with me > Source/WebKit2/ChangeLog:9 > + takes care of newly loaded contents having same size with previous one. takes care -> would take care having -> with with -> as >> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374 >> + m_contentsSize = IntSize(); > > Noam, could you take a look this ? I think this is fine. Comment on attachment 218094 [details]
Patch
Please land this patch after fixing things Noam points out.
Committed r159901: <http://trac.webkit.org/changeset/159901> (In reply to comment #5) > (From update of attachment 218094 [details]) > Please land this patch after fixing things Noam points out. landed after fixed Noam's comment. Thanks. |