Bug 125025

Summary:

Finally remove those DFG_ENABLE things

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, buildbot, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	sam: review+, eflews.bot: commit-queue-
patch for landing	none

Filip Pizlo

Reported 2013-11-29 20:59:23 PST

Using C preprocessor macros to control the internal debugging functionality of a compiler is insane. It means that the debug support isn't tested all the time, it isn't even built all the time, and it makes it challenging to read the code because of a bunch of #if's littered in the most complex places (after all it's the most complex algorithms that need debug prints). We now have Options::verboseCompilation and friends, which doesn't suffer as many of those problems. We should get rid of the old DFG_ENABLE preprocessor flags, because this will cleanse the codebase of the insanity and it will guide would-be DFG hackers towards the right way of getting debug dumps (i.e. the commandline options).

Attachments
the patch (69.08 KB, patch) 2013-11-29 21:03 PST, Filip Pizlo	sam: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (69.67 KB, patch) 2013-11-29 21:53 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.