Bug 125025

Summary: Finally remove those DFG_ENABLE things
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Severity: Normal CC: barraclough, buildbot, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
the patch
sam: review+, eflews.bot: commit-queue-
patch for landing none

Description Filip Pizlo 2013-11-29 20:59:23 PST
Using C preprocessor macros to control the internal debugging functionality of a compiler is insane.  It means that the debug support isn't tested all the time, it isn't even built all the time, and it makes it challenging to read the code because of a bunch of #if's littered in the most complex places (after all it's the most complex algorithms that need debug prints).

We now have Options::verboseCompilation and friends, which doesn't suffer as many of those problems.

We should get rid of the old DFG_ENABLE preprocessor flags, because this will cleanse the codebase of the insanity and it will guide would-be DFG hackers towards the right way of getting debug dumps (i.e. the commandline options).
Comment 1 Filip Pizlo 2013-11-29 21:03:19 PST
Created attachment 218085 [details]
the patch
Comment 2 Sam Weinig 2013-11-29 21:13:57 PST
Comment 3 EFL EWS Bot 2013-11-29 21:30:58 PST
Comment on attachment 218085 [details]
the patch

Attachment 218085 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/39978148
Comment 4 Build Bot 2013-11-29 21:37:20 PST
Comment on attachment 218085 [details]
the patch

Attachment 218085 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/39918130
Comment 5 Filip Pizlo 2013-11-29 21:46:35 PST
The build fails are because I forgot to give this release build love; the fixes are all trivial.
Comment 6 Filip Pizlo 2013-11-29 21:53:02 PST
Created attachment 218087 [details]
patch for landing

This one should work.
Comment 7 Filip Pizlo 2013-11-30 09:21:05 PST
Landed in http://trac.webkit.org/changeset/159886