Bug 125012

Summary: Fix build warning in WebKit2
Product: WebKit Reporter: Tibor Mészáros <mtiborinf>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, gyuyoung.kim, hausmann, kling, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v3 none

Description Tibor Mészáros 2013-11-29 06:54:44 PST
There are some unused parameter warning in WebKit2 during building.
Comment 1 Tibor Mészáros 2013-11-29 06:55:17 PST
Created attachment 218059 [details]
Patch

fix unused parameter warnings
Comment 2 Tibor Mészáros 2013-11-29 07:00:56 PST
Created attachment 218061 [details]
Patch v2

Missed the bugzilla link from the previous patch.
Comment 3 Csaba Osztrogonác 2013-11-29 07:49:28 PST
Comment on attachment 218061 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=218061&action=review

> Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp:42
> +    UNUSED_PARAM(array);

You can simple remove the name of the parameter as you did it in Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1390
> +    UNUSED_PARAM(pluginSize);
> +    UNUSED_PARAM(appletElement);
> +    UNUSED_PARAM(paramNames);
> +    UNUSED_PARAM(paramValues);

URL is unused too.
Comment 4 Tibor Mészáros 2013-11-29 08:20:12 PST
Created attachment 218067 [details]
Patch v3

As you mentioned, I take these changes on previous patch.
Comment 5 Csaba Osztrogonác 2013-11-29 08:21:31 PST
(In reply to comment #3)
> URL is unused too.
Ah, it isn't a parameter name.
Comment 6 Csaba Osztrogonác 2013-11-29 08:27:10 PST
Comment on attachment 218067 [details]
Patch v3

LGTM, but it needs WK2 owner review.
Comment 7 WebKit Commit Bot 2013-11-29 20:11:05 PST
Comment on attachment 218067 [details]
Patch v3

Clearing flags on attachment: 218067

Committed r159882: <http://trac.webkit.org/changeset/159882>
Comment 8 WebKit Commit Bot 2013-11-29 20:11:09 PST
All reviewed patches have been landed.  Closing bug.