Bug 125003

Summary: [EFL] HTML5 required attribute validation messages implemented
Product: WebKit Reporter: Attila Dusnoki <adusnoki>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, ossy, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch
none
Proposed patch none

Description Attila Dusnoki 2013-11-29 01:41:51 PST 
Implemented missing HTML5 validation messages.
Comment 1 Attila Dusnoki 2013-11-29 01:43:10 PST 
Created attachment 218040 [details]
Proposed patch
Comment 2 Attila Dusnoki 2013-11-29 02:26:13 PST 
Created attachment 218045 [details]
Proposed patch
Comment 3 Gyuyoung Kim 2013-11-30 21:33:56 PST 
Comment on attachment 218045 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218045&action=review

> Source/WebCore/ChangeLog:7
> +

It would be nicer to add description, though patch is too simple.

> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:531
> +    return String::fromUTF8("Please match the requested format:");

As far as I know, ASCIILiteral is more efficient than String::fromUTF8().

http://trac.webkit.org/wiki/EfficientStrings
Comment 4 Attila Dusnoki 2013-12-02 00:23:48 PST 
Created attachment 218144 [details]
Proposed patch
Comment 5 Gyuyoung Kim 2013-12-02 00:41:04 PST 
LGTM
Comment 6 WebKit Commit Bot 2013-12-02 01:05:46 PST 
Comment on attachment 218144 [details]
Proposed patch

Clearing flags on attachment: 218144

Committed r159915: <http://trac.webkit.org/changeset/159915>
Comment 7 WebKit Commit Bot 2013-12-02 01:05:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Gyuyoung Kim 2013-12-02 03:28:58 PST 
EFL layout test regression occurred. So, I fix it on http://trac.webkit.org/changeset/159929.