| Summary: | Revert the X86 assembler peephole changes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nadav Rotem <nrotem> | ||||
| Component: | New Bugs | Assignee: | Nadav Rotem <nrotem> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Nadav Rotem
2013-11-28 11:03:44 PST
Created attachment 218019 [details]
Patch
This patch reverts: https://bugs.webkit.org/show_bug.cgi?id=124904 Comment on attachment 218019 [details]
Patch
No need for review because I am only reverting a previous change.
Comment on attachment 218019 [details]
Patch
CQ won't land _without_ r+ and _with_ "Reviewed by NOBODY (OOPS!).", so rs=me for now.
If you would like to land unreviewed patch, just remove this line and don't set review flag.
(In reply to comment #4) > (From update of attachment 218019 [details]) > CQ won't land _without_ r+ and _with_ "Reviewed by NOBODY (OOPS!).", so rs=me for now. > If you would like to land unreviewed patch, just remove this line and don't set review flag. Or just svn commit directly! Also there's usually no need for a bug for rollouts. Rollouts and build fixes usually just have a changelog message like "Unreviewed, revert r1234" or "Unreviewed, fix build". No need for the other changelog stuff. We're not terribly strict about how you do it though. Comment on attachment 218019 [details] Patch Clearing flags on attachment: 218019 Committed r159855: <http://trac.webkit.org/changeset/159855> All reviewed patches have been landed. Closing bug. |