Bug 124988

Summary: Revert the X86 assembler peephole changes
Product: WebKit Reporter: Nadav Rotem <nrotem>
Component: New BugsAssignee: Nadav Rotem <nrotem>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nadav Rotem
Reported 2013-11-28 11:03:44 PST
Revert the X86 assembler peephole changes
Attachments
Patch (8.54 KB, patch)
2013-11-28 11:04 PST, Nadav Rotem 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nadav Rotem
Comment 1 2013-11-28 11:04:00 PST
Created attachment 218019 [details] Patch
Nadav Rotem
Comment 2 2013-11-28 11:04:26 PST
This patch reverts: https://bugs.webkit.org/show_bug.cgi?id=124904
Nadav Rotem
Comment 3 2013-11-28 11:06:49 PST
Comment on attachment 218019 [details] Patch No need for review because I am only reverting a previous change.
Csaba Osztrogonác
Comment 4 2013-11-28 11:34:56 PST
Comment on attachment 218019 [details] Patch CQ won't land _without_ r+ and _with_ "Reviewed by NOBODY (OOPS!).", so rs=me for now. If you would like to land unreviewed patch, just remove this line and don't set review flag.
Filip Pizlo
Comment 5 2013-11-28 11:50:46 PST
(In reply to comment #4) > (From update of attachment 218019 [details]) > CQ won't land _without_ r+ and _with_ "Reviewed by NOBODY (OOPS!).", so rs=me for now. > If you would like to land unreviewed patch, just remove this line and don't set review flag. Or just svn commit directly! Also there's usually no need for a bug for rollouts. Rollouts and build fixes usually just have a changelog message like "Unreviewed, revert r1234" or "Unreviewed, fix build". No need for the other changelog stuff. We're not terribly strict about how you do it though.
WebKit Commit Bot
Comment 6 2013-11-28 12:31:08 PST
Comment on attachment 218019 [details] Patch Clearing flags on attachment: 218019 Committed r159855: <http://trac.webkit.org/changeset/159855>
WebKit Commit Bot
Comment 7 2013-11-28 12:31:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.