Summary: | [CSS Regions] Fix Layout/RegionsSelection.html in Mac platform | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
Component: | Tools / Tests | Assignee: | Manuel Rego Casasnovas <rego> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jfernandez, mihnea, rniwa, WebkitBugTracker | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 124281 | ||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2013-11-28 01:55:40 PST
Created attachment 217987 [details]
Patch
Comment on attachment 217987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217987&action=review > PerformanceTests/Layout/resources/regions.js:95 > + window.getSelection().setBaseAndExtent(paragraphs[0], 0, paragraphs[i], 0); setBaseAndExtent is a non-standard API so perhaps we want to use collapse & extend? Also, we don't need "window.". Created attachment 218335 [details]
Patch
Comment on attachment 218335 [details] Patch Clearing flags on attachment: 218335 Committed r160041: <http://trac.webkit.org/changeset/160041> All reviewed patches have been landed. Closing bug. |