Bug 124961

Summary: Perform some spring cleaning to WKContentView and WKView
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim, nick.diego, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+, eflews.bot: commit-queue-

Sam Weinig
Reported 2013-11-27 23:26:43 PST
Perform some spring cleaning to WKContentView and WKView
Attachments
Patch (30.09 KB, patch)
2013-11-27 23:42 PST, Sam Weinig 		mitz: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-11-27 23:42:31 PST
Created attachment 217983 [details] Patch
mitz
Comment 2 2013-11-28 00:08:38 PST
Comment on attachment 217983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217983&action=review > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:28 > #import "WKContentViewInternal.h" > +#import "WKContentViewPrivate.h" This shouldn’t be needed. Internal should import Private. > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:39 > +#import "WKProcessGroupInternal.h" > #import "WKProcessGroupPrivate.h" Private should be imported by Internal. > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:66 > + // FIXME: Implement. > + return nil; Should release self before returning nil from an initializer. > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:72 > - if (!(self = [super initWithFrame:frame])) > + self = [super initWithFrame:frame]; > + if (!self) Why?
EFL EWS Bot
Comment 3 2013-11-28 00:26:58 PST
Comment on attachment 217983 [details] Patch Attachment 217983 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/39388002
mitz
Comment 4 2013-11-28 12:33:10 PST
Comment on attachment 217983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217983&action=review > Source/WebKit2/UIProcess/API/ios/WKView.mm:28 > #import "WKView.h" > +#import "WKViewPrivate.h" No need for #import "WKView.h"
Sam Weinig
Comment 5 2013-11-28 12:58:29 PST
Committed r159859: <http://trac.webkit.org/changeset/159859>
Nick Diego Yamane (diegoyam)
Comment 6 2013-11-28 16:38:07 PST
Bug to fix gtk build: https://bugs.webkit.org/show_bug.cgi?id=124992
Note You need to log in before you can comment on or make changes to this bug.