Bug 124943

Summary: Checkout should own the scm object in Host
Product: WebKit Reporter: Dániel Bátyai <dbatyai.u-szeged>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Dániel Bátyai
Reported 2013-11-27 08:35:27 PST
Checkout should own the scm object in common/host.py
Attachments
Proposed patch (1.61 KB, patch)
2013-11-27 08:36 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Proposed patch (1.56 KB, patch)
2013-11-28 05:05 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dániel Bátyai
Comment 1 2013-11-27 08:36:10 PST
Created attachment 217955 [details] Proposed patch
Ryosuke Niwa
Comment 2 2013-11-28 02:36:02 PST
Comment on attachment 217955 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=217955&action=review > Tools/Scripts/webkitpy/common/host.py:82 > + scm = detector.default_scm(patch_directories) > + self._checkout = Checkout(scm) It seems like Checkout's constructor could simply take patch_directories. If not, we could do all of this in one line.
Dániel Bátyai
Comment 3 2013-11-28 05:05:17 PST
Created attachment 217989 [details] Proposed patch
WebKit Commit Bot
Comment 4 2013-11-28 05:43:48 PST
Comment on attachment 217989 [details] Proposed patch Clearing flags on attachment: 217989 Committed r159838: <http://trac.webkit.org/changeset/159838>
WebKit Commit Bot
Comment 5 2013-11-28 05:43:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.