Bug 124943

Summary: Checkout should own the scm object in Host
Product: WebKit Reporter: Dániel Bátyai <dbatyai.u-szeged>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Description Dániel Bátyai 2013-11-27 08:35:27 PST 
Checkout should own the scm object in common/host.py
Comment 1 Dániel Bátyai 2013-11-27 08:36:10 PST 
Created attachment 217955 [details]
Proposed patch
Comment 2 Ryosuke Niwa 2013-11-28 02:36:02 PST 
Comment on attachment 217955 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217955&action=review

> Tools/Scripts/webkitpy/common/host.py:82
> +        scm = detector.default_scm(patch_directories)
> +        self._checkout = Checkout(scm)

It seems like Checkout's constructor could simply take patch_directories.
If not, we could do all of this in one line.
Comment 3 Dániel Bátyai 2013-11-28 05:05:17 PST 
Created attachment 217989 [details]
Proposed patch
Comment 4 WebKit Commit Bot 2013-11-28 05:43:48 PST 
Comment on attachment 217989 [details]
Proposed patch

Clearing flags on attachment: 217989

Committed r159838: <http://trac.webkit.org/changeset/159838>
Comment 5 WebKit Commit Bot 2013-11-28 05:43:49 PST 
All reviewed patches have been landed.  Closing bug.