Bug 124943 - Checkout should own the scm object in Host
Summary: Checkout should own the scm object in Host
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 08:35 PST by Dániel Bátyai
Modified: 2013-11-28 05:43 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (1.61 KB, patch)
2013-11-27 08:36 PST, Dániel Bátyai 		no flags Details | Formatted Diff | Diff
Proposed patch (1.56 KB, patch)
2013-11-28 05:05 PST, Dániel Bátyai 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dániel Bátyai 2013-11-27 08:35:27 PST 
Checkout should own the scm object in common/host.py
Comment 1 Dániel Bátyai 2013-11-27 08:36:10 PST 
Created attachment 217955 [details]
Proposed patch
Comment 2 Ryosuke Niwa 2013-11-28 02:36:02 PST 
Comment on attachment 217955 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217955&action=review

> Tools/Scripts/webkitpy/common/host.py:82
> +        scm = detector.default_scm(patch_directories)
> +        self._checkout = Checkout(scm)

It seems like Checkout's constructor could simply take patch_directories.
If not, we could do all of this in one line.
Comment 3 Dániel Bátyai 2013-11-28 05:05:17 PST 
Created attachment 217989 [details]
Proposed patch
Comment 4 WebKit Commit Bot 2013-11-28 05:43:48 PST 
Comment on attachment 217989 [details]
Proposed patch

Clearing flags on attachment: 217989

Committed r159838: <http://trac.webkit.org/changeset/159838>
Comment 5 WebKit Commit Bot 2013-11-28 05:43:49 PST 
All reviewed patches have been landed.  Closing bug.