Bug 124936

Summary: moveDoubleToInts should be used in SpecializedThunkJIT::returnDouble
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, msaboff, oliver, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for JSVALUE32_64 ports.
none
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. none

Julien Brianceau
Reported 2013-11-27 06:11:36 PST
In current SpecializedThunkJIT::returnDouble of JSVALUE32_64 ports, moveDoubleToInts function from macro assembler is likely to be more efficient than the current generic implementation using the stack.
Attachments
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for JSVALUE32_64 ports. (1.76 KB, patch)
2013-11-27 06:13 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. (1.98 KB, patch)
2013-11-29 08:24 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-11-27 06:13:08 PST
Created attachment 217946 [details] Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for JSVALUE32_64 ports.
Zoltan Herczeg
Comment 2 2013-11-29 06:34:15 PST
I suspect the point of the original code to avoid changing of src, which is returned by returnDouble(...). We might need to keep the original code path on x86.
Julien Brianceau
Comment 3 2013-11-29 06:38:59 PST
(In reply to comment #2) > I suspect the point of the original code to avoid changing of src, which is returned by returnDouble(...). We might need to keep the original code path on x86. You're right, I didn't see that, thanks. I'm going to check all 32-bit architectures moveDoubleToInts then submit a new patch with #if CPU(xx) condition.
Julien Brianceau
Comment 4 2013-11-29 08:24:44 PST
Created attachment 218068 [details] Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.
Zoltan Herczeg
Comment 5 2013-11-29 08:56:24 PST
Comment on attachment 218068 [details] Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. nice patch. r=me
WebKit Commit Bot
Comment 6 2013-11-29 09:23:18 PST
Comment on attachment 218068 [details] Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. Clearing flags on attachment: 218068 Committed r159873: <http://trac.webkit.org/changeset/159873>
WebKit Commit Bot
Comment 7 2013-11-29 09:23:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.