Bug 124920

Summary:

Build warnings in DownloadAuthenticationClient.cpp

Product:

WebKit

Reporter:

Tamas Gergely <tgergely.u-szeged>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, commit-queue, darin, galpeter, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix build warnings	none

Description Tamas Gergely 2013-11-27 02:42:29 PST

There are build warnings in DownloadAuthenticationClient.cpp since r159441.

Comment 1 Tamas Gergely 2013-11-27 02:47:11 PST

Created attachment 217933 [details]
Fix build warnings

Comment 2 Alexey Proskuryakov 2013-12-04 10:06:07 PST

It's unfortunate that some ports enable unused argument warnings in WebKit2, and others don't. I remember way too many patches to fix build breakage on ports that do.

Comment 3 WebKit Commit Bot 2013-12-04 10:32:51 PST

Comment on attachment 217933 [details]
Fix build warnings

Clearing flags on attachment: 217933

Committed r160101: <http://trac.webkit.org/changeset/160101>

Comment 4 WebKit Commit Bot 2013-12-04 10:32:53 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Darin Adler 2013-12-04 11:42:43 PST

Are these warnings off on the Mac port because of Objective-C?