Bug 124920

Summary: Build warnings in DownloadAuthenticationClient.cpp
Product: WebKit Reporter: Tamas Gergely <tgergely.u-szeged>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, darin, galpeter, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix build warnings none

Tamas Gergely
Reported 2013-11-27 02:42:29 PST
There are build warnings in DownloadAuthenticationClient.cpp since r159441.
Attachments
Fix build warnings (2.19 KB, patch)
2013-11-27 02:47 PST, Tamas Gergely 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tamas Gergely
Comment 1 2013-11-27 02:47:11 PST
Created attachment 217933 [details] Fix build warnings
Alexey Proskuryakov
Comment 2 2013-12-04 10:06:07 PST
It's unfortunate that some ports enable unused argument warnings in WebKit2, and others don't. I remember way too many patches to fix build breakage on ports that do.
WebKit Commit Bot
Comment 3 2013-12-04 10:32:51 PST
Comment on attachment 217933 [details] Fix build warnings Clearing flags on attachment: 217933 Committed r160101: <http://trac.webkit.org/changeset/160101>
WebKit Commit Bot
Comment 4 2013-12-04 10:32:53 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2013-12-04 11:42:43 PST
Are these warnings off on the Mac port because of Objective-C?
Note You need to log in before you can comment on or make changes to this bug.