Bug 124899 – [cmake] Fix cmake warning: Argument not separated from preceding token by whitespace

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Laszlo Vidacs]

Fix cmake (v2.8.11+) warnings like:

CMake Warning (dev) at Source/cmake/OptionsEfl.cmake:172 (find_package):
  Syntax Warning in cmake code at

    /home/elecro/work/webkit/WebKit/Source/cmake/FindGStreamer.cmake:97:45

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  CMakeLists.txt:137 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

[Laszlo Vidacs]

Created attachment 217900 [details]
Patch

[Peter Gal]

LGTM (sadly I'm not a reviewer :( )

[Ryuan Choi]

Comment on attachment 217900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217900&action=review

> Source/cmake/FindGStreamer.cmake:97
> -    message(FATAL_ERROR "Required version ("${GStreamer_FIND_VERSION}") is higher than found version ("${GSTREAMER_VERSION}")")
> +    message(FATAL_ERROR "Required version (" ${GStreamer_FIND_VERSION} ") is higher than found version (" ${GSTREAMER_VERSION} ")")

Just removing " is also fine.

[WebKit Commit Bot]

Comment on attachment 217900 [details]
Patch

Clearing flags on attachment: 217900

Committed r159866: <http://trac.webkit.org/changeset/159866>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.