Bug 124889

Summary: Move methods which belong to Checkout
Product: WebKit Reporter: Dániel Bátyai <dbatyai.u-szeged>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Description Dániel Bátyai 2013-11-26 06:54:36 PST
Moved methods which belong to Checkout into checkout.py

FIXME: This belongs in Checkout, not SCM.
def scripts_directory(self):
FIXME: This belongs in Checkout, not SCM.
def script_path(self, script_name):
Comment 1 Dániel Bátyai 2013-11-26 06:56:26 PST
Created attachment 217878 [details]
Proposed patch
Comment 2 Ryosuke Niwa 2013-11-26 07:13:45 PST
Comment on attachment 217878 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217878&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:276
> -        return self.run([self.script_path("svn-create-patch")] + changed_files,
> +        script_path = self._filesystem.join(self.checkout_root, "Tools", "Scripts", "svn-create-patch")
> +        return self.run([script_path] + changed_files,

Why are we not moving this method to Checkout?
Comment 3 Dániel Bátyai 2013-11-26 07:20:17 PST
(In reply to comment #2)
> Why are we not moving this method to Checkout?

Because the method form the supercalss is called, and if I moved it, I'd have to move it from both SVN and Git, but then I would also have to figure out somehow which one to call, since it's not obvius from the superclass, and that would just be a huge hack, unless I'm missing something.
Comment 4 WebKit Commit Bot 2013-11-26 17:24:53 PST
Comment on attachment 217878 [details]
Proposed patch

Clearing flags on attachment: 217878

Committed r159796: <http://trac.webkit.org/changeset/159796>
Comment 5 WebKit Commit Bot 2013-11-26 17:24:55 PST
All reviewed patches have been landed.  Closing bug.