| Summary: | [GTK] Enable web audio by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, gustavo, mrobinson, pnormand | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alberto Garcia
2013-11-26 06:52:02 PST
Created attachment 217877 [details]
Patch
How is test coverage? We should probably get some rough consensus to ship this feature. How is test coverage? Most webaudio tests pass. Currently flagged: webkit.org/b/79203 webaudio/mediastreamaudiodestinationnode.html [ Skip ] webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Skip ] webkit.org/b/105296 webaudio/delaynode-max-nondefault-delay.html [ Failure ] webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure ] webkit.org/b/105296 webaudio/delaynode-scheduling.html [ Failure ] webkit.org/b/105299 webaudio/javascriptaudionode.html [ Failure ] I think it's safe to ship it... Moreover the enable-webaudio setting is off by default, so in the end it's up to the application developer to enable it or not. Adding Carlos and Gustavo. What do you think about enabling WebAudio by default? (In reply to comment #6) > Adding Carlos and Gustavo. > > What do you think about enabling WebAudio by default? I don't see why not +1 from me Committed r160215: <http://trac.webkit.org/changeset/160215> |